XIO

xWire

Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.

Extensions activity

Justin Wernick approved merge request !1621: fix: Match :-abp-contains() on elements nested in non-matching ones [OM-1808] at eyeo / Browser Extensions and P...

Summary Fixes :-abp-contains() (and :has-text()) skipping elements nested inside an element that doesn't match, without slowing down filters that can't be affected. ContainsSelector.getElements() skipped every descendant of an element it had tested, even when that element's text didn't match. For most patterns that's safe: if a nested element's text matches, its ancestors' textContent contains the same text unbroken, so they match too. It's not safe for regular expressions that depend on the…

Vitalie Maldur closed merge request !1626: Draft: test: Add filter matches performance test for the service worker [FO-7] at eyeo / Browser Extensions and Pr...

Context We plan to collect which network filters matched on which site. Before writing that code, we need a reproducible way to show it does not make the extension worse. This MR adds only the test harness and changes no SDK source. It gives baseline numbers for today's build and is what the later changes will be measured with. It is a draft until the pipeline has run once, because the time the new test adds to the performance job on CI runners is not measured yet. Description New filter…

Vitalie Maldur opened merge request !1636: Draft: test: Measure the service worker on local pages in the performance tests [FO-7] at eyeo / Browser Extension...

Context We plan to collect which network filters matched on which site. Before writing that code, we need a reproducible way to show it does not make the extension's service worker slower or heavier. Lighthouse on live sites cannot show that, it measures the page and varies a lot between runs. This is the second of two MRs split from !1626 (closed) and it is stacked on !1635. It changes no SDK source, only the test setup. It is a draft until !1635 is merged and the pipeline has run once,…

Vitalie Maldur opened merge request !1635: Draft: test: Run the lighthouse performance tests against the host extensions [FO-7] at eyeo / Browser Extensions ...

Context We plan to collect which network filters matched on which site. Before writing that code, we need a way to see what a change costs in AdBlock and Adblock Plus, not only in the SDK's test extension. This is the first of two MRs split from !1626 (closed). It only adds the host extensions to the lighthouse tests we already have, with the baseline we already have. Description New --extension={performance|adblock|adblockplus} option for test:performance. The default is the SDK's test…

Alexandru Mihai accepted merge request !1628: feat: Show a notice while only language-only lists are enabled without EasyList [LOVEAB-118] at eyeo / Browser ...

Summary Implements LOVEAB-118. Stacked on !1620 (merged), so it targets feat/LOVEAB-72-language-list-pickers. New installs get EasyList plus language-only lists (!1613 (merged)). If the user removes or turns off EasyList, the language-only lists only block ads on websites in their language, and without a language list nothing blocks most ads. Adblock Plus doesn't say so. AdBlock has a notice for this (#easylist_info). This MR adds one to Adblock Plus's settings page, which answers LOVEAB-72's…

Alexandru Mihai approved merge request !1628: feat: Show a notice while only language-only lists are enabled without EasyList [LOVEAB-118] at eyeo / Browser ...

Summary Implements LOVEAB-118. Stacked on !1620 (merged), so it targets feat/LOVEAB-72-language-list-pickers. New installs get EasyList plus language-only lists (!1613 (merged)). If the user removes or turns off EasyList, the language-only lists only block ads on websites in their language, and without a language list nothing blocks most ads. Adblock Plus doesn't say so. AdBlock has a notice for this (#easylist_info). This MR adds one to Adblock Plus's settings page, which answers LOVEAB-72's…

Justin Wernick commented on merge request !1621 at eyeo / Browser Extensions and Premium / Extensions / Extensions

You noted that this would have a performance impact for these filters, since they would be checking on every element. Did you do any testing of real sites with this change to check if there were significant performance impacts? As a follow-up suggestion, since regex anchors are the problem, maybe this change could only apply to filters that use a regex with anchors?

Alexandru Mihai opened merge request !1623: chore: Remove the unused AdBlock language filter list translations [Ref LOVEAB-100] at eyeo / Browser Extensions ...

Context Part of LOVEAB-100: removing AdBlock's betafish-subscriptions.json and identifying filter lists the same way as Adblock Plus. Since !1617 (merged), the language filter lists are labelled with the native names of their languages, so their old translations are no longer used. Independent of !1619. Description Removed 92 unused translation keys from all locales: The 39 labels of the language filter lists that !1617 (merged) stopped using, e.g. filtereasylist_plus_german and…

Alex Gibson approved merge request !1608: feat: Add blockedPerDay fact for block count cohorts [LOVEAB-73] at eyeo / Browser Extensions and Premium / Extensi...

Summary Blocks eyeo/filters/ab-testing-config!255 Adds a blockedPerDay fact for the block count cohorts in LOVEAB-73. The SDK computes it, so AdBlock and Adblock Plus both get it without changes of their own. blockedPerDay is blockedCount ÷ (UTC days since installDate + 1), rounded down, so on the install day it equals the total so far. The SDK derives it in getAllFacts from those two host facts (core/sdk/src/background/remote-config/blocked-per-day.js). It's left undefined when the install…