XIO

xWire

Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.

gtk activity

fætalize commented on issue #8524 at GNOME / gtk

what's your take on it, @matthiasc ? browsers rarely hit this issue since the page root is usually opaque. but on a desktop environment, translucent toplevels aren't uncommon. would you take a deviation here? a composite node with source instead of source-over fixes it on all 3 renderers. we'd limit it to blur-like filters so backdrop-filter: opacity() doesn't punch holes in opaque windows ofc I feel like it might be worth pursuing since Gnome recently started supporting background effects,…

Benjamin Otte commented on merge request !10626 at GNOME / gtk

Everything this MR changes I think (I didn't try too hard to understand Claude's junk) is that the first rendering is always made to match Cairo and the 2nd rendering will always fail, when previously we had a canonical "correct" rendering. So if you do this: transform { transform: translate(100.01, 0); child: fill "f" { path: "M0 0 h 10 v 10 h-10 z"; } } "f"; The 2nd rectangle will be blurry, too.

Benjamin Otte commented on merge request !10626 at GNOME / gtk

Yes, you did that intentionally because you wanted to avoid cache blowups in animations, from your experience with fonts. That's why the function named determine_scale_and_subpixel_grid() exists. So what you are going to get is this: fill "f" { ... } transform { transform: translate(100.01, 0); child: "f"; } And those two should render the same with the GPU renderer and different with Cairo, because the GPU renderer only wants to fill 1 cache entry for both while the Cairo renderer redraws them…

fætalize commented on issue #8524 at GNOME / gtk

Filter Effects 2 ends the operation with step 7: "Composite the contents of T' into element B's parent, using source-over compositing." Read literally, the original is still there underneath, so Chromium and GTK fit the wording and Firefox is the odd one out So is it really a bug? But it looks completely wrong..

Matthias Clasen commented on merge request !10626 at GNOME / gtk

The argument is that we ignored the off-grid offset of the path bounds by using the snapped position as the origin of the grid. Thats this change: + gx = path_bounds.origin.x - bounds->origin.x; + gy = path_bounds.origin.y - bounds->origin.y; if (!gsk_rect_snap_to_grid_grow (&viewport, scale, - &GRAPHENE_POINT_INIT ((float) fx / (sx * subpixel_scale), - (float) fy / (sy * subpixel_scale)), + &GRAPHENE_POINT_INIT (gx, gy), &viewport)) The comparison with the cairo rendering proves that correct -…

Benjamin Otte closed merge request !10626: gpu: Fix pixel grid alignment for cached fill and stroke masks at GNOME / gtk

The GPU renderer caches Cairo-rendered paths as masks. The cached image's pixel grid was misaligned with the output pixel grid when path bounds had fractional device-pixel positions, causing antialiasing differences versus direct Cairo rendering. Use the exact fractional offset between path_bounds.origin and the grid-snapped bounds origin as the grid_offset for snap_to_grid_grow. This value (path_bounds.origin - bounds->origin) captures the precise fractional device-pixel position including…

fætalize commented on issue #8524 at GNOME / gtk

ok checked a few more things. same 18 cells are wrong on vulkan, gl and cairo so it's not a single renderer. 4.24.1 renders pixel-identical to main at 6f3377c8, so it's not a recent regression either. seen on wayland under gnome shell and niri. if you have a window background in your gtk.css it'll override the one in the repro, run it with XDG_CONFIG_HOME=$(mktemp -d)

Matthias Clasen opened merge request !10626: gpu: Fix pixel grid alignment for cached fill and stroke masks at GNOME / gtk

The GPU renderer caches Cairo-rendered paths as masks. The cached image's pixel grid was misaligned with the output pixel grid when path bounds had fractional device-pixel positions, causing antialiasing differences versus direct Cairo rendering. Use the exact fractional offset between path_bounds.origin and the grid-snapped bounds origin as the grid_offset for snap_to_grid_grow. This value (path_bounds.origin - bounds->origin) captures the precise fractional device-pixel position including…

fætalize commented on issue #8524 at GNOME / gtk

I'm gonna add more context cuz I tried to pin point exactly in which cases the blur failed: puts the same bar over every combination of 5 window backgrounds, 5 layers between the window and the bar, and text on either the window or the layer, 50 cells in all. Each cell stands in for a window inside one transparent toplevel, and the bar uses blur(8px) to suit the cell size attached matrix.c it seems like the blur is most likely composited over the original backdrop instead of replacing it, so it…

fætalize opened issue #8524: backdrop-filter leaves the unfiltered backdrop visible on translucent windows at GNOME / gtk

Welp, I've been playing a lot with transparency and blur ever since Mutter introduced support for effects. One thing I noticed, illustrated below, is that a blur NEEDS something opaque sitting at the end of the stack, otherwise things look very wrong. Left: transparent window > text > blurred control. the text is legible and the yellow rectangle is slightly fuzzed Right: window is given a background-color. The above reproduction is in repro.c, attached below: repro.c cc repro.c -o repro…

Luca Bacci approved merge request !10554: win32: Make the keymap follow the layout tables like Windows does at GNOME / gtk

The win32 keymap translates a (vk, modifiers, CapsLock) state to a keyval by reading the keyboard layout DLL tables itself. A systematic comparison with ToUnicodeEx() showed several places where it disagreed with Windows. This series fixes them. The comparison (a standalone test, not part of the series) asks both ToUnicodeEx() and gdk_display_translate_key() about every virtual key in every Shift/Ctrl/Alt combination with CapsLock off and on (16 states) on all 218 installed layouts, and sorts…

Marge Bot accepted merge request !10534: win32: real per-layout display names, cached metadata, activation-free KLID decode at GNOME / gtk

Summary GdkWin32Keymap's per-layout display names, and the way it learns each installed layout's KLID, both treat a Win32 HKL as simpler to decode than it actually is. Three focused commits: Resolve the real per-layout display name (TSF profile -> registry -> locale fallback), cached once per layout instead of recomputed, instead of mis-using the KLID as an LCID. Cache two more descriptive fields (BCP-47 language tag, IME/TSF profile id) and log all of it under the existing GDK_DEBUG=input…

Marge Bot closed issue #8516: GTK Leaks image textures when they are loaded as data-urls at GNOME / gtk

Steps to reproduce Here's a small self contained repro: #include static const char png_base64[] = "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/" "9hAAAAGUlEQVR4nGP4z8DwnxLMMGrAqAGjBgwXAwAwxP4QHCfkAAAAAABJRU5ErkJggg=="; static guint created, released; static void (*texture_constructed)(GObject *); static void texture_released(gpointer data, GObject *object) { ++released; } static void texture_constructed_override(GObject *object) { texture_constructed(object); ++created; g_object_weak_ref(object,…

Marge Bot accepted merge request !10597: css: fix data-image resource leak on textures at GNOME / gtk

Fixes #8516 (closed) Using the repro program from the issue before: luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak textures created=200 released=0 luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak direct textures created=200 released=200 after fix: [gtk] luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak textures created=200 released=200 [gtk] luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak direct textures created=200 released=200

Matthias Clasen approved merge request !10597: css: fix data-image resource leak on textures at GNOME / gtk

Fixes #8516 (closed) Using the repro program from the issue before: luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak textures created=200 released=0 luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak direct textures created=200 released=200 after fix: [gtk] luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak textures created=200 released=200 [gtk] luna@luna-pc:~/Documents/tmp/gtk$ ./_build/css_leak direct textures created=200 released=200