XIO

xWire

Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.

Issues for all projects

Drupal core: Navigation toolbar footer items are missing “current is-active” classes

Problem/Motivation The menu items in the top portion of the navigation bar have the proper classes: <a class="toolbar-button current is-active"> In <div id="menu-footer" class="admin-toolbar__footer"> the “current is-active” classes are missing in the <a> tag. The view / edit profile links use user.page and user.edit redirect to the current user's edit/view profile page. Steps to reproduce Click on “View profile” and check the menu item <a> tag. Proposed resolution Replace the routes with…

Admin Toolbar: Admin toolbar tools: Improve support for core Navigation

Problem/Motivation This task is a follow-up to #3556081: Admin Toolbar Tools: Remove dependency on Admin Toolbar, where an initial step towards better compatibility with the core navigation module was taken, but more refinements, better integration and more testing probably needs to be done. With very little, basic testing, a few issues have been identified: The third level menu links don't seem to be displayed. The "Tools Help" link Drupal logo icon doesn't seem to be displayed properly. Other…

Display Builder: Remove Update button from ContextualFormPanel

Problem/Motivation There is this button in ContextualFormPanel: $build['update'] = [ '#type' => 'button', '#value' => 'Update', '#submit_button' => FALSE, '#attributes' => [ 'type' => 'button', 'data-wysiwyg-fix' => TRUE, ], ]; Which have its own logic in HtmxEvent::onInstanceUpdateButtonClick(). ContextualFormPanel seems to work well without it now and this create visual noise, some confusion ("do I need to click on it?") and uncessary code. Proposed resolution Can we remove it? Is it still…

Drupal core: Define core gate for &#039;developer tooling&#039;

Problem/Motivation To define the core gate for the proposed 'developer tooling' topic maintainer. Steps to reproduce Proposed resolution phpstan-drupal or drupal-rector detect the deprecation When is this needed? When a deprecation is added and PHPStan does not report an error. Details phpstan-drupal or drupal-rector can fix the deprecation When is this needed? When a deprecation is added and PHPStan does not report an error. Details A BC snippet is added to the change record When is this…

Drupal core: &quot;Member for&quot; needs a div tag instead of h4 to pass accessibility check

Problem/Motivation In D10.4 / 10.5 Editora11y complains about a h4 tag in /user/<user id>?ed1ref=/user/<user id> because the previous level h3 was skipped. Steps to reproduce Open a member page on a site with with CKeditor and Editora11y installed. The accessibility information icon in the bottom right corner shows a warning about the headings not following a sequential order. Or, scan the page using the Deque Axe browser extension with “best practice” rules enabled. Proposed resolution Change…

Admin Toolbar: Make obvious when toolbar search returning no results

Problem/Motivation When searching via the admin toolbar search field, if there are no results, nothing happens and there is no evidence that a search was performed. Without doing another search, it's not possible to tell whether there are no results or if something is not working. It may be nice to have a simple "No results found" message appear for cases where there are no matches. Steps to reproduce Do a search for something with no results and see that nothing happens. Proposed resolution…

SMTP Authentication Support: Implement OAuth support for Microsoft Exchange Online

Problem/Motivation On Apr 15, 2024, Microsoft Exchange Team announced that Exchange Online will permanently remove support for Basic authentication with Client Submission (SMTP AUTH) in September 2025 (exact date to be determined). After this time, applications and devices will no longer be able to use Basic auth as an authentication method and must use OAuth when using SMTP AUTH to send email. During September 2025, Exchange Online will remove support for Basic auth with the Client Submission…

Google Tag: Getting empty array on ajax response

Problem/Motivation After upgrading the module to 2.0.8, the file upload using the default Drupal core media is not working Steps to reproduce Install google_tag, media, and media_library module. got to content -> media -> Add media ->Image Try to upload an image. Proposed resolution Looks like a JS issue that prevents uploading the file. In the ajax response I am getting empty array Remaining tasks User interface changes API changes Data model changes

Drupal core: [PP-1] Autodetect available CPUs in run-tests.sh for concurrency

Postponed on #3589422: run-tests.sh - separate run progress reporting to a class. Problem/Motivation run-tests.sh provides a --concurrency argument to determine the concurrent parallel subprocesses to be executed. This currently requires a determinate value. Proposed resolution Use the fidry/cpu-core-counter to autodetect the number of available CPUs; allow an auto value for the --concurrency argument in run-tests.sh to indicate self detection. Explicitly require fidry/cpu-core-counter as a dev…

Email Confirmer: One-time login link confirms user mail when mail sent to another address

We have a profile node associated with user accounts that has a multivalue email field. We can use this to send an invitation email to one of the emails in that field, unrelated to what the user account email address might be. The email contains a one-time login link for the user. If the user opens the one-time login link and logs in, a confirmation entity is created for their user account email. But the mail didn't go to the user account email address. I would expect it to not create any kind…

Drupal core: Remove unneeded phps:ignore Drupal.Commenting.FunctionComment.Missing

Problem/Motivation There are instances in core of the following but there is a doc block and the Drupal.Commenting.FunctionComment.Missing shouldn't be needed. It was added as a workaround to an error from phpcs. // phpcs:ignore Drupal.Commenting.FunctionComment.InvalidReturn, Drupal.Commenting.FunctionComment.Missing The files where the sniff is ignored. $ git grep phpcs:ignore | grep Drupal.Commenting.FunctionComment.Missing core/lib/Drupal/Core/Extension/DatabaseDriver.php: // phpcs:ignore…

WordPress Migrate Recipe for Drupal CMS: Promote the WordPress Migrate Recipe for Drupal CMS module

Problem/Motivation This is a great idea, and I hope it succeeds! Perhaps a link could be added on the https://www.drupal.org/project/wordpress_migrate project page, linking to the "WordPress Migrate Recipe for Drupal CMS" project, to help it get some more users? I added it to the FAQ doc page, under "Can I migrate from WordPress into Drupal CMS?" https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... Steps to reproduce Proposed resolution Remaining tasks User interface…

CAPTCHA: Allow the settings form to accept longer Description and Error text to avoid data loss

Problem/Motivation The captcha.settings description has no limit as a text string in configuration, but the CAPTCHA settings form prevents input greater than 256 characters. It is then possible to import a longer description, but then lose that description if a user saves the form. We should avoid data loss. Either the settings should also be constricted to 256 characters or a different form element is used to allow for longer text strings. I think that there is not a reason to limit the number…

CAPTCHA: Incorrect path handling - Image Captcha Submodule

Problem/Motivation We got dinged in a recent security scan for the image-captcha-refresh URL. The refresh controller for the image captcha submodule responds with HTTP 200 to any request to the base captcha refresh path, even when the path includes invalid extensions or additional text. Example https://example.com/image-captcha-refresh/webform_submission_contact_add_form.exe https://example.com/image-captcha-refresh/webform_submission_contact_add_form.asdfadf These invalid paths should return…

Automatic Updates: WSOD when installing already downloaded modules without active public internet connection

Problem/Motivation Installing a locally downloaded module with automatic_updates installed and no active public internet connection throws a RuntimeException and WSOD. Steps to reproduce Install Drupal CMS Add the following to settings.php (to simulate a network failure, or proxy failure). $settings['http_client_config']['proxy']['http'] = 'http://127.0.0.1:63000'; $settings['http_client_config']['proxy']['https'] = 'http://127.0.0.1:63000'; Attempt to install a module that is already…

Leaflet: replace &lt;u&gt; with &lt;em&gt; in ui strings

Problem/Motivation Dear Leaflet developers, The release of Drupal CMS is getting closer and closer and Leaflet is part of this new standard download for Drupal. Unfortunately, when translating all modules used in Drupal CMS into German, I could not avoid Leaflet either. Since we have a great interest in ensuring that additional modules provided by the community can be translated 100%, I hereby request that the strings, the originals of which can be found at the following link, be modified.…

Drupal core: TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given in array_key_exists()

Problem/Motivation During configuration import (drush cim) or database updates (drush updb), a fatal error occurs in the CKEditor 5 module: TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given This error originates from Ckeditor5Hooks::editorPresave() when array_key_exists() is called on a null value. The issue is caused by malformed or outdated CKEditor 5 configuration. In particular: * The plugins key may be missing or not an array * The ckeditor5_list plugin…

External Links: Make sure aria-label is used correctly throughout

I'm using this module for a11y purposes. We need a description of icons used in inline texts. This module enables us to put an aria-label on the icon. Recently updated from 2.0.2 to 2.0.4 (to fix unrelated bug). Now the area-label for external links is not on the icon wrapper anymore, but on the link (anchor). Screen readers will now read this label f.e. "(external link)", instead of link text.

Simplify: Vertical tab is visible when all items are hidden

Problem/Motivation After issue https://www.drupal.org/project/simplify/issues/3081745 was released, empty vertical tabs with revision are visible again Original fix: https://www.drupal.org/project/simplify/issues/3367206 Steps to reproduce - enable Simplify - on a content type enable all "Simplify the following options" - edit a node - revisions are visible Proposed resolution Set groups to type = hidden or class = visually-hidden.

CAPTCHA: CAPTCHA fails every time for dynamically-loaded forms via AJAX with a cached form state

Problem/Motivation When a form is loaded, the CAPTCHA module stores processed versions of the form ID and posted form ID in the form state. It then checks that these two values match before releasing the CAPTCHA session ID for use. For regular forms loaded via GET request, this is fine since the form state won't be cached, so _captcha_get_posted_captcha_info() will always follow the "else" path on submission and find the form's actual posted form ID. For forms which are dynamically-loaded via…

CAPTCHA: &quot;Warning: array_flip() in EntityStorageBase::loadMultiple() Skipping Non-Scalar Values&quot;

Steps to reproduce Install and enable the CAPTCHA module along with any custom modules that interact with entity loading. Warning: array_flip(): Can only flip string and integer values, entry skipped in Drupal\Core\Entity\EntityStorageBase->loadMultiple() (line 278 of /var/www/alien/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php) #0 /var/www/alien/web/core/includes/bootstrap.inc(166): _drupal_error_handler_real() #1 [internal function]: _drupal_error_handler() #2…

IEF Complex Widget Dialog: Error: Call to a member function getComponent() on null in ief_popup_inline_entity_form_entity_form_alter()

Problem/Motivation Install the IEF module, IEF popup module, and layout paragraphs, select layout paragraphs in the display field of a content type. Add and edit a node through the form. View logs Error: Call to a member function getComponent() on null in ief_popup_inline_entity_form_entity_form_alter() (line 151 of /var/www/html/web/modules/contrib/ief_popup/ief_popup.module). Proposed resolution Just add a conditional before the code. if (!in_array('inline_entity_form',…

Visitors (Web Analytics): Visitors Event: Search Plugin

Problem/Motivation I want to be able to track: Keyword - record count Referrer Keyword, and page number Referrer Bounce Rate<> I want to track these metric over time. Steps to reproduce Proposed resolution Category: Search Keyword Page Total results Filter Event Search - a new start Next - same keyword, different page, same filters Previous - Next, but previous page Filter - Same Keyword, page 0, other query arguments change - sort query arguments so identical filters match Keyword - the…

Drupal core: Supported attribute(s) not showing in CKEditor 5 Source Editing plugin error message

Problem/Motivation When modifying "Manually editable HTML tags", there is an error message said The following attribute(s) are already supported by enabled plugins and should not be added to the Source Editing "Manually editable HTML tags" field: . The supported attribute's name is missing from the error message. An expected error message is supported to provide the specific attribute name that is overlapped with plugins. Such as, The following attribute(s) are already supported by enabled…