XIO

xWire

Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.

Issues for all projects

User Guide: [meta] Documentation for dr commands in the user guide

Documentation location/URL To be determined (TBD) Problem/Motivation The CLI in Core Initiative has landed several new commands in addition to existing Drupal core commands under the dr console application. User guide readers should learn about commands either replacing the existing Drush user guide (since Drush is EOL). This is issue is intended to help plan user guide documentation efforts. Proposed resolution There should be a strategy/plan for updating user guide documentation for 11.x-dev…

Footnotes: References linked to wrong citation when references content are the same in Footnotes Group Block with JS Grouping enabled

Problem/Motivation when you have 2 or more reference with the same content like, <footnotes data-text="Same Reference Content" data-value="">&nbsp;</footnotes> ... more text content <footnotes data-text="Same Reference Content" data-value="">&nbsp;</footnotes> the references in footnote group block would always link to the first one. Steps to reproduce 1. install footnotes module 2. add footnote group block to layout with group using javascript enabled 3. add footnote filter to text format 3.…

Drupal.org security advisory coverage applications: [1.1.x] OOXML Sanitizer

The module strips author, company, and custom document properties from uploaded Office Open XML files. ExifTool cannot rewrite these zip-based formats, so this complements Metadata Sanitizer and similar ExifTool-based tools. On file insert and when a managed file is replaced (URI change), it opens matching Office packages with PHP ZipArchive and removes: docProps/core.xml (creator, last modified by, and related Dublin Core fields) docProps/app.xml (application / company metadata)…

Drupal core: Add the &quot;ShareEnvironment&quot; attribute to all Kernel tests

Problem/Motivation After #1411074: Allow kernel tests to share the test environment, we need to complete the adoption of the new #[ShareEnvironment] attribute. Most Kernel tests either work out of the box or require very trivial changes to support the "shared environment" mode, so it might be possible to handle everything here. Proposed resolution Add the #[ShareEnvironment] attribute to all core Kernel tests. Opt out via #[ShareEnvironment(FALSE)] any Kernel test requiring a non-trivial…

Drupal core: Create OOP replacement for hook_install_tasks and hook_install_tasks_alter

Problem/Motivation It would be good to deprecate the .profile file extension, but currently hook_install_tasks and hook_install_tasks_alter still only support procedural implementations. Steps to reproduce N/A Proposed resolution Create TasksInterface and require it to be in a consistent namespace Drupal\PROFILE_NAME\Install\Tasks This will implement two methods, one for getTasks and one for alter. We will only check for the procedural version if there is no OOP version. Remaining tasks Decide…

Gutenberg: Content block usage tracking is not revision-aware and can delete blocks still used

Problem/Motivation Non-reusable Gutenberg content blocks can be deleted even though they are still referenced by the current/default revision of a node. The problem shows up with moderated content. When a pending draft revision is saved without a content block that still exists in the published/default revision, Gutenberg marks the block usage as inactive for the whole entity. After 24 hours, gutenberg_cron() treats the inactive usage record as an orphan and deletes the block_content entity.…

Drupal core: Create closure properties for UserController

Problem/Motivation Postponed on #3620912: Deprecate user.module cancel methods From godotislate: This can be a closure, since it's only used in one method and not relevant to the large majority of requests. I missed seeing the same thing for the login/logout finalizers, so we can do those two and accountCancellation all as a follow up. The form class properties are fine as is, because theoretically forms can be serialized, so we can't have closure properties. Steps to reproduce Proposed…

Drupal core: Introduce a differ for SchemaDefinitionInterface objects

Problem/Motivation Given SchemaDefinitionInterface value objects are immutable, it's worth developing a specific differ that could extract the changes that occurred between two different versions of the same SchemaDefinitionInterface definition. That could help further automating the database updates. Proposed resolution Remaining tasks User interface changes Introduced terminology API changes Data model changes Release notes snippet

Drupal core: Numeric views field passes the formatted value as the plural count, triggering a warning

Problem/Motivation NumericField::render() formats the value and then hands the formatted string to the plural machinery as the count: $value = number_format($value, $precision, $this->options['decimal'], $this->options['separator']); if (!empty($this->options['format_plural'])) { $value = PluralTranslatableMarkup::createFromTranslatedString($value, $this->options['format_plural_string']); } If we have already a separator set in the views field, like a comma (kind of normal in US when showing a…

Drupal core: Only download artifacts we actually need during CI pipelines

Problem/Motivation with-composer jobs have 'needs' for phpcs and phpstan, but as well as /vendor this also downloads the phpstan and phpcs caches, which we don't want. See https://docs.gitlab.com/ci/yaml/#needsartifacts Steps to reproduce Proposed resolution To avoid downloading massive caches to 15+ different test jobs, always run the composer job and get artifacts only from there. Remaining tasks User interface changes Introduced terminology API changes Data model changes Release notes snippet

Entity Browser: Regression from #3552528: entities-list--single-item replaces entities-list instead of adding to it, breaking themes built on the combined class

Problem/Motivation #3552528 changed EntityReferenceBrowserWidget::displayCurrentSelection() so that cardinality-1 fields get entities-list--single-item instead of entities-list, rather than as an additional modifier. Gin's own CSS (entity_browser.scss) was already written expecting both classes together — e.g. .entities-list:not(.entities-list--single-item) and .entities-list.entities-list--single-item .item-container only match when entities-list is still present. With it dropped, every rule…

Key: Drupal 12 support - Will it be 2.x only, or 1.x as well?

Problem/Motivation Key is in a transition as 2.x is developed (currently on alpha 1). Drupal 12 is coming in December. What are the Key maintainers' plans to support Drupal 12? Will support be added to 2.x only, or 1.x as well? People are contributing Drupal 12 fixes for both 2.x and 1.x at the moment, so it would be great to get clarity on this to avoid wasted work.

Drupal core: Stop relying on drupalSettings.path.currentQuery, read from window.location instead

Problem/Motivation Found while digging into #3011426: Page cache size is unlimited when arbitrary query parameters are requested (page cache bloat from arbitrary query strings). SystemHooks::jsSettingsAlter() (hook_js_settings_alter) reads $request->query->all() and dumps it into drupalSettings.path.currentQuery on every page with a query string. No cache context declared for it anywhere. active-link.js is the only Drupal Core consumer (core/misc/active-link.js) of it. Uses…

Drupal core: Deprecate .module file extension

Problem/Motivation There are no more functions I am aware of that must reside in .module files, magic autoloading of .module files can be the source of some very hard to find bugs. There is a simple script to assist with converting the hooks in modules and remaining functions can almost just be copy pasted. We should deprecate the .module file extension Important to note: This is not about deprecating the Extension type of module, just the procedural .module files. Steps to reproduce N/A…

Drupal.org security advisory coverage applications: [1.0.x] Cookie Control Premium from CIVIC

Cookie Control Premium is a consent management platform (CMP) built for teams who want to be compliant without spending time on manual setup and configuration. It scans your site to discover what cookies and scripts are active, generates a ready-to-deploy consent banner through a guided wizard, and keeps everything up to date as your site changes with regular, scheduled audits. The end result for your visitors is a familiar consent banner — they choose which categories of cookies to accept or…

Drupal core: Allow dumping of the container during the installer

Problem/Motivation The UI installer rebuilds the dependency container on every request and sometimes more than once during a request when modules or themes are installed. For tests and probably the CLI, this is fine, because there is only one 'request' and then the rest of the install happens inside it. For the UI installer, there are pages like the site settings form and translation import that don't trigger a container rebuild, and these are unnecessarily slow. A container rebuild can easily…

Drupal core: Add a way to provide tokens to views result summary

Problem/Motivation Result::render() can handle tokens like @total, @page, etc. But it is not possible to hide a new token without extending the module. It would be useful to have a hook that allows adding new tokens. Steps to reproduce Proposed resolution Add a hook that lets modules add values to $replacements. Remaining tasks User interface changes Introduced terminology API changes Data model changes Release notes snippet

Drupal core: Registry::init() re-resolves a named theme on every call

Generated with the help of an LLM. Problem/Motivation Found on 11.3. main is not affected: #3575542: Remove deprecations related to the theme preprocess discovery and theme.inc removed the named-theme branch of init(). Registry::$initialized is declared and read, but never assigned anywhere in core, and reset() does not touch it either — so the early return in init() never fires. With no theme name that costs little, because ThemeManager::getActiveTheme() is statically cached. With a name it is…

Drupal core: Memoize ContextHandler::getMatchingContexts() per operand pair

Generated with the help of an LLM. Problem/Motivation ContextDefinition::isSatisfiedBy() is pure with respect to its two operands — the same definition asked about the same context object cannot answer differently within a request — but it is expensive: it builds constraint objects, may generate sample entities through EntityContextDefinition::getSampleValues(), and runs the validator. Callers ask it the same question repeatedly. Layout Builder is the extreme case:…

Drupal core: Prefer persistent transport sharing for HTTP client requests

Problem/Motivation Ideally, Drupal core could enable persistent transport sharing for HTTP client requests. This allows requests to share connections, DNS, and TLS sessions across multiple PHP executions. For example, batch operations could continue a series of HTTP client requests to the same host without a DNS lookup, reconnecting and renegotiating TLS. Steps to reproduce Time the HTTP client requests in e.g. Update Status module, and notice that each time you click "Check manually," ~100ms…

Drupal core: TypedDataManager prototype cache returns wrong type/constraints for Map/List properties with identical names but different definitions

Problem/Motivation TypedDataManager::getPropertyInstance() builds each child property from a cached prototype. The cache key is the root's data type and settings plus the property path, not the property's own definition. So when two different definitions have a property with the same name, the second one gets the first one's prototype: the wrong typed data class, the wrong constraints, or an exception. For example, a constraint is silently ignored: $tdm = \Drupal::typedDataManager(); // Map A:…

Drupal core: Add helpful link if there are no content types

Problem/Motivation If there are no content types defined, attempting to enable a workflow for content types gets a no-options dialog. It would be helpful to explain why the dialog is blank and provide a remediation link. Steps to reproduce Steps: 1. Go to simplytest.me 2. Create a site with the current version of Drupal (11.4.4) 3. Log in as admin 4. Go to /admin/modules 5. Enable Content Moderation and Workflows 6. Go to /admin/config/workflow/workflows 7. On the row for Editorial, click Edit…

Drupal core: Reduce ComposerInspector/ComposerValidator work in package_manager

Problem/Motivation Found via profiling package_manager tests. Package manager calls composer validation multiple times per request via various call paths, I think we can just do that once per request. Steps to reproduce Proposed resolution Remaining tasks User interface changes Introduced terminology API changes Data model changes Release notes snippet

Drupal core: [11.4 regression] LoggerAwarePass crashes container compilation when a LoggerAwareInterface service (e.g. DrupalConsoleLogger) is decorated

Problem/Motivation `CoreServiceProvider` auto-tags every service implementing `Psr\Log\LoggerAwareInterface` with `logger_aware`. `LoggerAwarePass` then requires every `logger_aware`-tagged service to implement that interface, throwing `InvalidArgumentException` otherwise. This breaks container build as soon as such a service is decorated by a class that does not itself implement `LoggerAwareInterface` — a usual decoration pattern. Steps to reproduce Needs an update, as per #14 this should have…

Admin Toolbar: ExtraLinks::getDerivativeDefinitions() docblock incompatible with DeriverInterface after Drupal 11.4.0

Problem/Motivation Since Drupal 11.4.0, DeriverInterface::getDerivativeDefinitions() accepts array|PluginDefinitionInterface as the parameter type (#3587110). In the admin_toolbar_tools module, ExtraLinks::getDerivativeDefinitions() overrides the inherited PHPDoc and declares the parameter type as array<mixed>. This matched the parent definition prior to Drupal 11.4.0, but is no longer compatible with the parent signature starting with Drupal 11.4.0. This causes issues for static analysis tools…

Migrate Plus: Migrate Plus compatibility with Drupal 12

Problem/Motivation Migrate Plus module is not compatible with Drupal 12. Users cannot install or use Migrate Plus with Drupal 12 sites, preventing data migration workflows. Steps to reproduce 1. Install a fresh Drupal 12 site 2. Attempt to install Migrate Plus module 3. Enable the module 4. Try to create or run a migration 5. Observe compatibility errors Proposed resolution Update Migrate Plus to be fully compatible with Drupal 12 by: - Updating dependencies - Fixing deprecated API calls -…

xmlrpc: Automated Drupal 12 compatibility fixes for xmlrpc 1.x-dev

Problem/Motivation Hello project maintainers, This is an automated issue to help make this module compatible with Drupal 12. Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates. The changes will be…