XIO

xWire

Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.

Issues for all projects

Admin Toolbar: Focus indication clashes with active tab indication

Problem/Motivation The current major section of the toolbar is indicated via a difference in contrast. However, Focus is also indicated by the same difference and contrast. Further, the contrast between the inactive unfocused sections and the active and inactive focused sections is insufficient. For instance, while on /admin/modules, with Local tasks active, I tabbed to Manage. - Manage and local tasks have the same appearance. - The contrast between the backgrounds of the inactive unfocused…

Signature Field: Change color

Problem/Motivation When need change color for pen or pad this error apear in create new node. Drupal 10.2.4 Deprecated function: Invalid characters passed for attempted conversion, these have been ignored in _signature_field_color_unpack() (line 59 of modules/contrib/signature_field/signature_field.module). If no custom color, no has any errors. Steps to reproduce Proposed resolution Remaining tasks User interface changes API changes Data model changes

Wordcloud: Automated Drupal 11/12 compatibility fixes for wordcloud

Problem/Motivation Hello project maintainers, This is an automated issue to help make this module compatible with Drupal 11. Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates. The changes will be…

Custom Search: Automated Drupal 11 compatibility fixes for custom_search

Problem/Motivation Hello project maintainers, This is an automated issue to help make this module compatible with Drupal 11. Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates. The changes will be…

Drupal core: [November 2026] Bump PHPStan rule level to 3

Problem/Motivation How about bumping PHPStan rule level to 3 before D12 is shipped, e.g. during the beta phase? The baseline will likely be at its lowest after all the deprecated D11 code will have been removed, before new deprecations will start getting in. Also, the PHPStan2 and 3 preparation issues have been lingering forever, not much focus; bumping the level and adding to the baseline, even if it will bring a large amount of errors, would potentially drive the focus on the fixes. Proposed…

Google Tag: Missing options to edit Label and Machine name for a container

Problem/Motivation I recently updated a project from Drupal 8.9 to Drupal 10. The old versions used the old version of Google Tag Manager module and the new one uses now Google Tag 2.0.2. I enabled the option to create multiple containers than I add a new container but there no option to edit label or machine name. They are assigned automatically. Image attached to see the current status. Steps to reproduce Enable the module Google Tag Enable the option "Allow multiple Tag Containers" on the…

Google Tag: Missing options to order containers by weight

Problem/Motivation I recently updated a project from Drupal 8.9 to Drupal 10. The old versions used the old version of Google Tag Manager module and the new one uses now Google Tag 2.0.2. I enabled the option to create multiple containers and when I tried to order them using the weight I couldn't find the option like in other listing pages to order items by weight. Moreover there is no option to adjust the weight by editing the item. Image attached to see the current status. Steps to reproduce…

Drupal core: Increase size of alternative text field in Image dialog

Problem/Motivation The alternative text field in the CKEditor5 image dialog only allows for about 35 characters. This places a cognitive load on content editors whenever appropriate alternative text requires more than 35 characters. My understanding is that ideal alternative text is about 127 characters or less. It would be better, whenever the alternative text needs to be larger than the field size, to have the default be that all such alternative text is visible while the content editor is…

CAPTCHA: Can't get it to work

Problem/Motivation So I installed CAPTCHA with composer, set "Add CAPTCHA challenges on all forms", navigated to my form at /contact/join (the one I created from my /admin/structure/contact page), but there's no captcha there. Okay, so I see there's something called Captcha Points that I need to configure. I go to add a CAPTCHA point but i'm not sure what a "Form ID" refers to or where to find that. Quite a few search results later I've got some varying answers to this so I try every single one…

SAML Authentication: Avoid reusing an valid SAML assertion sent from IDP

Problem/Motivation The Authentication Request and Assertion are sent via browser redirects so they pass through the user’s browser. This makes them easy to steal via techniques such as cross site scripting or malicious plugins. Proposed resolution Check SubjectConfirmationData's NotOnOrAfter property in the SAML authentication response. This is supported by the Saml PHP toolkit (no need to dissect XML), and it gives us a good sense of how long we should remember previous assertions coming in…

SAML Authentication: SAML nested assertion

Problem/Motivation When the IdP returns its response, the assertion is nested, hence there are two and not one assertion, and the authentication is rejected with the error: 'Error(s) encountered during processing of authentication response. Type(s): invalid_response; reason given for last error: SAML Response must contain 1 assertion.' I have applied a temporary fix by modifying the public function validateNumAssertions() located in vendor/onelogin/php-saml/src/Saml2/Response.php (line 855) in…

Drupal core: [regression] CKEditor 5 throws an exception when the default theme is not installed

Problem/Motivation Themes can add CSS to CKEditor 5 with the ckeditor5-stylesheets key in their .info.yml file. To find that CSS, Ckeditor5Hooks::themeCss() reads the .info.yml of the default theme (from system.theme:default). It reads it with ThemeExtensionList::getExtensionInfo(), which only knows about installed themes. If the theme is not installed, it throws UnknownExtensionException. This means that building the library list throws an exception. themeCss() runs from…

Drupal.org security advisory coverage applications: [1.0.x] Media/Document Notifier

The Media Notifier module empowers Drupal administrators by email notifications whenever a new media or file is uploaded. Leveraging Drupal's SMTP settings, ensures timely alerts, making media management more efficient. It is ideal for those new to Drupal seeking an automated media upload notification system. Project link https://www.drupal.org/project/medianotify

Flag: Create FlagCountManagerInterface::getFlagCounts()

Problem/Motivation It would be useful if FlagCountManager offered a method to count a particular flag. This would be like ::getEntityFlagCounts() except that it would also take a string flag_id param and return an integer, the count for that flag_id. Proposed resolution Add a new method. Remaining tasks Agree on the name of the method. Implement. User interface changes None. API changes Method is added. Data model changes None.

CAPTCHA: Allow using "default" #captcha_type for the captcha form element

Problem/Motivation When adding a captcha to a form by using the captcha form element, you can't simply use "default" as #captcha_type, while it would be nice to be able to do so. Currently you have to retrieve the default challenge from captcha like this: $default_challenge = \Drupal::service('config.manager') ->getConfigFactory() ->get('captcha.settings') ->get('default_challenge'); $form['captcha'] = [ '#type' => 'captcha', '#captcha_type' => $default_challenge, ]; For example see the famous…

Flag: Create FlagService::getFlagUserEntities()

Problem/Motivation It would be useful to be able to get an array of all entities that a user has flagged with a given flag, such as all article nodes they have bookmarked. Proposed resolution Add a method with code along these lines: $query = $this->entityTypeManager()->getStorage('flagging')->getQuery(); $query->accessCheck(FALSE); $query->condition('flag_id', FLAG_ID); $query->condition('uid', UID); $nids = $query->execute(); Remaining tasks Agree on name of method. Implement. User interface…

Drupal core: Log an error message when library definitions have a license with no URL defined

Problem/Motivation If you have a library without a url key, you currently get the mentioned PHP warning. That might not be a valid thing to do, but it happens, in our case it seems to be the colorbox module: colorbox: remote: https://github.com/jackmoore/colorbox version: VERSION license: name: MIT gpl-compatible: false js: /libraries/colorbox/jquery.colorbox-min.js: { minified: true } dependencies: - core/drupal - core/drupalSettings - core/jquery - core/once Steps to reproduce Proposed…

CAPTCHA: Create further persistence tests

Problem/Motivation The current persistence tests do not cover all cases and should be reworked. Or if the security issue is really riddler related, we should cover the problem in captcha as well. Steps to reproduce Proposed resolution Rework persistence tests. Remaining tasks User interface changes API changes Data model changes

Drupal core: Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in Drupal\Core\Routing\UrlGenerator->doGenerate()

Problem/Motivation Using PHP 8.1 and D9.5.2, I'm seeing a deprecated function warning on a view with an exposed form (show in block = true) where the exposed field is the "Combined fields filter", and only the Title field is selected. Steps to reproduce 1. Create a view with a title field 2. Add "Combine fields filter", and set it to exposed; in my case, the Title field is selected under "Choose fields to combine for filtering" 3. Under "Exposed Form", set "Exposed form in block" to "Yes" Error…

CAPTCHA: Replace bitwise operations in if clauses related to "_image_captcha_check_setup" calls

Problem/Motivation Currently, we are using many bitwise operations used for different if-clauses inside the module. This isn't very intuitive and should be replaced, with more comprehensible if clauses. Example from the install file: if (_image_captcha_check_setup(FALSE) & $image_captcha_error_no_gdlib) Steps to reproduce Proposed resolution If possible, move the whole logic inside "_image_captcha_check_setup". Remaining tasks User interface changes API changes Data model changes

Drupal core: Allow WebP quality to be configurable in GD2 image manipulation toolkit settings

Problem/Motivation According to PHP documentation when converting image to WebP quality argument can be passed to set the quality of the image. In gd.php default is set to 80% and there is no way to configure or change this value. function imagewebp($image, $to = null, $quality = 80): bool {} Steps to reproduce Go to /admin/config/media/image-toolkit Select GD2 for image processing Only JPEG quality is configurable not WebP. Proposed resolution Make the quality settings configurable and pass…

Commerce Variation Add-on: Add Quantity for Group Items

Problem/Motivation We should add group item quantities. Right now getting multiple of the same item requires adding it multiple times. See #3629227: Allow child variations to set a quantity Proposed resolution First step is to add the field to the group item and check the quantities when children are created and prices are calculated. One new quantity group item base field. User interface changes Need to sort out how to incorporate quantity widgets with all of the plugins. API changes Add the…

Drupal core: drupal_phpunit_find_extension_directories() uses infinite recursion ⇒ more directories = slower tests

Problem/Motivation Fresh D9 git clone, with only composer install and a core/phpunit.xml added: $ time vendor/bin/phpunit --configuration core/phpunit.xml core/modules/ckeditor5/tests/src/Kernel/ValidatorsTest.php PHPUnit 8.5.21 by Sebastian Bergmann and contributors. Testing Drupal\Tests\ckeditor5\Kernel\ValidatorsTest .............................. 30 / 30 (100%) Time: 20.33 seconds, Memory: 8.00 MB OK (30 tests, 50 assertions) real 0m20.421s user 0m8.002s sys 0m11.805s versus in my dev…

Drupal core: JSON API Exception response exposing database table name

Summary When a JSON API request contains an error related to the resulting mysql query, the error message gives too much structural information away in the error messaging. It should not be revealing away sql and table names and fields in the error. Extended Details When there is an exception in JSON API endpoint call for example if invalid value passed to an endpoint parameter JSON API response back with JSON object and details message looks something as below. Requesting a feature to hide…

Facets: Refactor taxonomy hierarchy plugin for performance

Problem/Motivation The page request is very slow with large hierarchical facets, we don't need the children lookup for every link. Steps to reproduce Enable the use hierarchy option, setup facets with hierarchical taxonomy vocabulary of 100+ items Proposed resolution #2-5: Replace getNestedChildIds with a faster method #7 onwards: Some static caching was added in #3005018: Improve performance for taxonomy hierarchical facets but still, this is far from great. A lot of entity loading happens in…

Redirect: Already encoded URLs are double-encoded, creating broken redirects

Problem/Motivation When add a redirect using the form, the "to" URL is url encoded before being saved. This is problem if pasting in a URL that is already encoded, as it double encodes it, breaking the redirect. Steps to reproduce Visit redirect form to add a new redirect For the "from" path, enter "test123" For the "to" path, enter "/sites/default/files/some%20file%20with%20spaces.txt" Save In redirect listing table, observe the redirect was saved as "/si…

Drupal core: EmbeddedFormWidgetTest::testInsertionAndReselection() may pass incorrectly

Problem/Motivation The EmbeddedFormWidgetTest::testInsertionAndReselection() method wraps a few waitForText() method calls with assertNotNull() assertions. While the JSWebAssert::waitForText() method technically can return a NULL value, it appears that it will only return a NULL value if there is a timeout during the execution of the callback function. This would likely be quite rare in this test. Most often, the method will return a boolean value. Since the method nearly always returns a…

Ultimate Cron: Module is incompatible with Drupal Configuration Sync processes

Problem/Motivation If you install this module on one environment and then export the configurations from that environment and import into another environment, the necessary tables don't get created and it puts the other environment in a broken state where you can't do anything with the cron because The Ultimate Cron tables do not exist. This is a huge problem because 1) You can't disable the module and reenable it to properly run the install scripts 2) You can't do anything with Ultimate Cron…