danger commented on merge request !1527 at ISC Open Source Projects / stork
1 Error 🚫 Branch name does not start with GitLab issue: piotrek-test 1 Warning ⚠️ This MR does not refer to an existing milestone Generated by 🚫 Danger
Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.
1 Error 🚫 Branch name does not start with GitLab issue: piotrek-test 1 Warning ⚠️ This MR does not refer to an existing milestone Generated by 🚫 Danger
anyway..did not change this code. please let me know if we need to change this in another issue
Razvan Becheriu (18d5f318) at 20 Oct 15:51 [#4226] added HA_DOWN_ST state
createPool* command is used whenever subnets are added/uppdated. The pool(s) are first deleted, then re-created. The remaining pool functions (e.g. MySqlConfigBackendDHCPv4Impl::getPool4(), getPools()) are not exposed by the API and the latter is currently only used to for the pool id in the former. For completeness the DDNS parameters could be added, but they would be fetched and then not used.
It does not cause an issue. I did fix a few unrelated errors though.
kea-test-results-write-repo (f2a08df2) at 16 Oct 21:10 Add Jenkins tests status report
Alessio Podda (7e6c44b2) at 16 Oct 20:32 Log dnstap size ... and 1 more commit
kea-test-results-write-repo (66c877e6) at 16 Oct 19:38 Add Jenkins tests status report
So far I have not been able to reproduce this with either 3.0.3 or master. Could you attach your primary and stand-by server config files (after redacting anything sensitive)?
kea-test-results-write-repo (d61c0a12) at 16 Oct 18:26 Add Jenkins tests status report
I see this is merged, but I hadn't gotten around to reviewing it yet, it was on my list for today. I don't see an approval from anyone else. Did someone read and approve it?
kea-test-results-write-repo (023c2fbf) at 16 Oct 18:23 Add Jenkins tests status report
kea-test-results-write-repo (46b983c8) at 16 Oct 16:49 Add Jenkins tests status report
kea-test-results-write-repo (88ca6d3f) at 16 Oct 16:20 Add Jenkins tests status report
kea-test-results-write-repo (d84088e2) at 16 Oct 16:12 Add Jenkins tests status report
kea-test-results-write-repo (bf894423) at 16 Oct 16:07 Add Jenkins tests status report
kea-test-results-write-repo (c1cefd6c) at 16 Oct 16:00 Add Jenkins tests status report
Duplicate conditions (copy-paste error) in commit cff08f7e. This was fixed in the next commit when the code was moved to notify.c.
dns_notifyctx_notify_needed() requires a second parameter. This error exists in 4f58eb5c and is fixed in the next commit. I'd fix it here so that the commit at least compiles. dns_notifyctx_notify_needed(&zone->notifysoa, now);
This block has been moved upper and placed under the if (commit) condition. I'd move that change into a different commit with some explanation in the commit message if possible.
Reading the flag uses "relaxed" ordering, while setting and clearing use "seq_cst". AFAIK, mixing operations with different memory orderings for the same memory location is an error. Maybe we could use "ack_rel" for all of them?
We could use a single instruction? return dns_notifyctx_hasflag(nctx, DNS_NOTIFY_NEEDSEND | DNS_NOTIFY_NEEDSTARTUP); If you agree, there are more places where consecutive dns_notifyctx_hasflag() calls can be replaced by a single one.
ad configurable fsync: RFC2136 3.5 - Stability When a zone is modified by an UPDATE operation, the server must commit the change to nonvolatile storage before sending a response to the requestor or answering any queries or transfers for the modified zone. but for secondary zones, it sounds like a good trade of to relax this requirement.
kea-test-results-write-repo (81827db7) at 16 Oct 15:39 Add Jenkins tests status report