XIO

xWire

Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.

ISC Open Source Projects activity

Štěpán Balážik commented on merge request !13026 at ISC Open Source Projects / BIND

I believe that 6c66f69f (which uses for_query with keyword arguments and reorders the calls in the body), together with the docstring change from 3e6214a1, makes the attack clear. What do you think? Alternatively, I prepared 6b922ef8, that does what you proposed. I really don't like that c.abc.example, an artifact of the default zone templates, is hardcoded there. The alternatives are last_nsec_owner = sorted( owner for owner, _ in abc_zone.iterate_rdatasets(dns.rdatatype.NSEC) )[-1] and…

Martin Basti accepted merge request !13028: fix: dev: Remove duplicated dns_db_commitupdate() call in ixfr_apply_one() at ISC Open Source Projects / BIND

Commit da53708d "Implement qpzone specific update path" added a second dns_db_commitupdate() call right above the existing one. It is harmless because commitupdate is required to be safe to double-call, but it is dead code with a comment that duplicates the one below it. Keep a single call and merge the two comments.

Michał Kępień commented on merge request !13013 at ISC Open Source Projects / BIND

This change does not really make sense to me. This exact step is already present on every release checklist. Whether there are CVEs in a release or not does not change anything, does it? The vulnerability matrix still needs to be updated. That being said, if it helps Support, it's fine with me. I should not be the one reviewing this :)

Michał Kępień approved merge request !12436: Draft: fix: ci: Improve issues and work items reference parsing at ISC Open Source Projects / BIND

Improve work_item and issue reference detection in dangerfile.py GitLab has moved issues from /-/issues/N to /-/work_items/N, and both URLs are now in use. Make dangerfile.py parse both forms and introduce a preferred style (via warning) for adding new links, `[...] prefer: Closes #xxxx, #yyyy, #zzzz for merge requests in the public BIND 9 project and: Closes isc-projects/bind9#xxxx, isc-projects/bind9#yyyy, isc-projects/bind9#zzzz for merge requests in any other project. This has the advantage…

Michał Kępień commented on merge request !12436 at ISC Open Source Projects / BIND

Okay, this looks ready to me. As pointed out above, please drop the topmost commit (596cbe3a), squash the rest, then merge and backport. Speaking of backports, any particular reason why this would only go back to v9.20? I would say this should be backported all the way to v9.11 as it's a process tweak. I'll adjust the labels accordingly, but feel free to challenge me on this if I am missing something.