Michal Nowak pushed to project branch main at ISC Open Source Projects / images
Michal Nowak (8ad35d70) at 02 Nov 21:35 Add AWS-LC to Alpine image
Posts from every feed QUEST has found across the web — blogs, news, podcasts, channels and more.
Michal Nowak (8ad35d70) at 02 Nov 21:35 Add AWS-LC to Alpine image
Piotrek Zadroga (d2b4c3f0) at 02 Nov 20:40 [#2780] changelog entry ... and 10 more commits
Piotrek Zadroga (5457bfb9) at 02 Nov 20:40 [#2780] Update Go and Go dependencies
Looks good to me. The updates look sensible, and the demo, python linting, and the documentation build all still work afterwards.
Looks good to me. The updates look sensible, and the demo, python linting, and the documentation build all still work afterwards.
Michal Nowak (8ad35d70) at 02 Nov 19:58 Add AWS-LC to Alpine image ... and 1 more commit
Michal Nowak (ebac72fb) at 02 Nov 19:56
Michal Nowak (ebac72fb) at 02 Nov 19:56 Add kryoptic 1.5.4
I believe that 6c66f69f (which uses for_query with keyword arguments and reorders the calls in the body), together with the docstring change from 3e6214a1, makes the attack clear. What do you think? Alternatively, I prepared 6b922ef8, that does what you proposed. I really don't like that c.abc.example, an artifact of the default zone templates, is hardcoded there. The alternatives are last_nsec_owner = sorted( owner for owner, _ in abc_zone.iterate_rdatasets(dns.rdatatype.NSEC) )[-1] and…
kea-test-results-write-repo (10fed9a0) at 29 Oct 11:04 Add Jenkins tests status report
Suzanne Goldlust (c6563137) at 29 Oct 11:03 [#4888] Update marketing section of checklist
1 Error 🚫 Do not submit MRs over 5000 lines of code. 2 Warnings ⚠️ Split the MR into separate ones. It's really big. ⚠️ Please limit commit subject line to 50 characters. 5e14cd39 Generated by 🚫 Danger
Martin Basti (177b61e3) at 29 Oct 10:58 fix: dev: Remove duplicated dns_db_commitupdate() call in ixfr_appl... ... and 1 more commit
Martin Basti (77b233de) at 29 Oct 10:58
Commit da53708d "Implement qpzone specific update path" added a second dns_db_commitupdate() call right above the existing one. It is harmless because commitupdate is required to be safe to double-call, but it is dead code with a comment that duplicates the one below it. Keep a single call and merge the two comments.
Razvan Becheriu (5e14cd39) at 29 Oct 10:57 [#4889] moved premium hook libraries to public repo
kea-test-results-write-repo (a81301c8) at 29 Oct 10:56 Add Jenkins tests status report
1 Error 🚫 Do not submit MRs over 5000 lines of code. 2 Warnings ⚠️ Split the MR into separate ones. It's really big. ⚠️ Please limit commit subject line to 50 characters. 4b147878 Generated by 🚫 Danger
Razvan Becheriu (4b147878) at 29 Oct 10:52 [#4889] moved premium hook libraries to public repo
This change does not really make sense to me. This exact step is already present on every release checklist. Whether there are CVEs in a release or not does not change anything, does it? The vulnerability matrix still needs to be updated. That being said, if it helps Support, it's fine with me. I should not be the one reviewing this :)
Original Zulip thread: link 💬1 I moved the Zulip link from the MR description to a separate comment as I would rather not have Zulip links in the changelog. ↩
1 Error 🚫 Do not submit MRs over 5000 lines of code. 2 Warnings ⚠️ Split the MR into separate ones. It's really big. ⚠️ Please limit commit subject line to 50 characters. f54f4e1a Generated by 🚫 Danger
Razvan Becheriu (f54f4e1a) at 29 Oct 10:42 [#4889] moved premium hook libraries to public repo
Improve work_item and issue reference detection in dangerfile.py GitLab has moved issues from /-/issues/N to /-/work_items/N, and both URLs are now in use. Make dangerfile.py parse both forms and introduce a preferred style (via warning) for adding new links, `[...] prefer: Closes #xxxx, #yyyy, #zzzz for merge requests in the public BIND 9 project and: Closes isc-projects/bind9#xxxx, isc-projects/bind9#yyyy, isc-projects/bind9#zzzz for merge requests in any other project. This has the advantage…
Okay, this looks ready to me. As pointed out above, please drop the topmost commit (596cbe3a), squash the rest, then merge and backport. Speaking of backports, any particular reason why this would only go back to v9.20? I would say this should be backported all the way to v9.11 as it's a process tweak. I'll adjust the labels accordingly, but feel free to challenge me on this if I am missing something.
That's a fair concern, but it's just a Danger warning, which does not even make the pipeline fail. I'd keep this behavior, thanks.